Vlan support #2084
Merged
Vlan support #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prob on configurable vlan, later on we need to also configure the privae bridge (zos) to use that configured vlan
- pub vlan is supported in both single and dual nic setup - delete some dead code
Also disable support for dual nic for now
muhamadazmy
requested review from
delandtj,
MarioBassem,
ashraffouda,
rawdaGastan and
xmonader
as code owners
xmonader
reviewed
Oct 19, 2023
| return "", false | ||
| } | ||
|
|
||
| return all[len(all)-1], true |
There was a problem hiding this comment.
does this mean it returns the last item in case of the item passed multiple times? if so, let's please document the behavior
There was a problem hiding this comment.
yes, if the same param is provided multiple times via a cmdline it's overridden by the last value provided. This way u can override hardcoded params in the image with whatever values u provide during booting
xmonader
previously approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for new boot params
vlan:priv(optional) sets the private subnet vlanvlan:pub(optional) sets the public subnet vlan (only in single node setup)Please read docs for more details.