adds flag to disable gpu #2067
Merged
adds flag to disable gpu #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashraffouda
requested review from
muhamadazmy,
delandtj,
MarioBassem,
rawdaGastan and
xmonader
as code owners
xmonader
reviewed
Oct 3, 2023
| @@ -41,6 +42,11 @@ func (k Params) IsDebug() bool { | |||
| return k.Exists(Debug) | |||
| } | |||
|
|
|||
| // GPUDisabled checks if gpu is diabled | |||
There was a problem hiding this comment.
it says GPUDisabled while the function is called GPUEnabled?
ashraffouda
force-pushed
the
main-disbale-gpu
branch
from
a1da26f to
0ebacdb
Compare
muhamadazmy
requested changes
Oct 3, 2023
cmds/modules/provisiond/api.go
Outdated
| @@ -71,6 +73,9 @@ func setupGPURmb(router rmb.Router, store provision.Storage) { | |||
| return gpus, nil | |||
| } | |||
| gpus.WithHandler("list", func(ctx context.Context, payload []byte) (interface{}, error) { | |||
| if kernel.GetParams().IsGPUDisabled() { | |||
| return nil, fmt.Errorf("gpu is disabled on this node") | |||
There was a problem hiding this comment.
Why return an error? this can just return an empty list. (no gpus)
There was a problem hiding this comment.
The client doesn't need to know if the farmer disable the GPU feature, all what he needs to know is that the node has no GPUs for renting
Signed-off-by: Ashraf Fouda <[email protected]>
ashraffouda
force-pushed
the
main-disbale-gpu
branch
from
0ebacdb to
4ded16c
Compare
muhamadazmy
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.