Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make icons aligned #815

Merged
merged 2 commits into from
Dec 30, 2024
Merged

make icons aligned #815

merged 2 commits into from
Dec 30, 2024

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented Dec 23, 2024 •
edited
Loading

Changes

  • make icons aligned with each other
  • Update message of tfchain secret.
    image

Related Issues

Tested Scenarios

A list of scenarios tried to match the deliverables

zaelgohary
zaelgohary reviewed Dec 24, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The copy icon is on a different level in each input. As for the TF Chain input, what if we set the copy icon next to the eye? Same styling should be applied to the stellar address.

@AlaaElattar AlaaElattar marked this pull request as draft December 25, 2024 07:58
@AlaaElattar AlaaElattar marked this pull request as ready for review December 29, 2024 11:29
@AlaaElattar AlaaElattar merged commit 2fabf7e into development Dec 30, 2024
1 check failed
@AlaaElattar AlaaElattar deleted the development_farm_align branch December 30, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlaaElattar @zaelgohary @AhmedHanafy725