Add Refresh button to node finder
#3748
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaradel
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar and
0oM4R
as code owners
|
cpd from #3737 |
maayarosama
approved these changes
Dec 15, 2024
amiraabouhadid
previously approved these changes
Dec 16, 2024
ramezsaeed
reviewed
Dec 16, 2024
There was a problem hiding this comment.
doesn't unreserve and doesn't reflect
https://www.loom.com/share/9fc9a7898e294466af53da5bfc33e364?sid=9756774f-2ae9-4192-bfee-17806cdbe5da
unreserving from solutions node finder is an open issue #3575. |
amiraabouhadid
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
reflects in node finder after a minute or so when refresh is clicked
https://www.loom.com/share/293de2127ef54594b5c7d05978320e45?sid=460218c9-bbee-4ee1-895e-402ede9c668f
|
@ramezsaeed @amiraabouhadid #3744 should fix that with the test scenarios too |
ramezsaeed
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check if the filter forms are valid or changed to apply the refresh button.
Changes
Screencast.from.15-12-24.13.32.36.webm
Related Issues
Tested Scenarios
Refreshbutton should appear and work.Applybutton instead and once it is applied the refresh button will be back.dedicatednode, and refresh after a while you'll find it disappears.Checklist