Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mycelium IP column in workers table #3743

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

Add mycelium IP column in workers table #3743

wants to merge 7 commits into from
+36 −4

Conversation

samaradel
Copy link
Contributor

Description

  • Add the MyCelium IP column in the worker's table.
  • Include myCelium in the worker deployment object.
  • Add Created At and Health columns.

Changes

Screencast.from.25-11-24.16.21.46.webm

Tested Scenarios

  • Go to Caprover solution
  • Deploy instance with worker and mycelium enabled
  • List the deployments
  • View the worker's table, the mycelium column should be there

Scenarios update

  • Create more than two workers and check that all have the mycelium IP column.
  • Create with planetary and no mycelium and check nothing in the mycelium column.
  • Delete a worker, add it again, and ensure mycelium ip changes.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel
Copy link
Contributor Author

cpd from #3590

@samaradel samaradel changed the title Development 2.7 worker with mycelium ip Add mycelium IP column in workers table Dec 15, 2024
@samaradel samaradel marked this pull request as ready for review December 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samaradel