Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rentableOrRentedBy query in dedicated filter #3740

Draft
wants to merge 4 commits into
base: development
Choose a base branch
from
Draft

Add rentableOrRentedBy query in dedicated filter #3740

wants to merge 4 commits into from

Conversation

samaradel
Copy link
Contributor

Description

  • Add rentableOrRentedBy query in the dedicated filter.
  • merging development branch.

Changes

Screencast.from.04-11-24.16.30.07.webm

Tested Scenarios

  • Go to any solution page
  • Toggle on the Dedicated node switch
  • Load Nodes and you'll find the nodes you already rented and the nodes that are available for you to rent

Scenarios Update

  • Rent a node and make sure it's not listed in the free dedicated nodes filter.
  • Unreserve the node and ensure it is back in the free dedicated node filter.
  • Try to deploy on a node not rented by you (should fail with proper error message)

Documentation PR

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel
Copy link
Contributor Author

cpd from #3587

0oM4R
0oM4R reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3587 (review)
still reproducable
Screenshot from 2024-12-16 11-08-35
Screenshot from 2024-12-16 11-08-21

also there are many unrelated changes please make sure to update the pr

@maayarosama
Copy link
Contributor

Please remove unrelated changes

@samaradel samaradel marked this pull request as draft December 18, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R left review comments

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samaradel @maayarosama @0oM4R