Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding worker with mycelium to k8s #3739

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix adding worker with mycelium to k8s #3739

merged 2 commits into from
Dec 18, 2024

Conversation

samaradel
Copy link
Contributor

Description

  • Check if myceliumNetworkSeed.seed is existed.
  • Remove .skip from add worker test case.

Changes

image

Tested Scenarios

  • Go to the Grid Client package
  • Run yarn test tests/modules/kubernetes.test.ts
  • All cases should pass

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel
Copy link
Contributor Author

cpd from #3565

AhmedHanafy725
AhmedHanafy725 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the workflow on the branch and the tests are passed
https://github.com/threefoldtech/tfgrid-sdk-ts/runs/34590999792#r0s10

@AhmedHanafy725 AhmedHanafy725 merged commit 49a091b into development Dec 18, 2024
13 of 14 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_2.7_k8s_with_mycelium branch December 18, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samaradel @AhmedHanafy725 @maayarosama