Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logger fix undefined err #3734

Merged
merged 1 commit into from
Dec 15, 2024
Merged

logger fix undefined err #3734

merged 1 commit into from
Dec 15, 2024

Conversation

amiraabouhadid
Copy link
Contributor

Changes

  • added a conditional to check if logs.value exists before pushing item to list

Related Issues

#3556

Tested Scenarios

  • start up playground, observed logs load correctly
  • did some transactions (transfer by twinID) observed logs get updated correctly, no console err from logger

image

@amiraabouhadid amiraabouhadid changed the base branch from development to development_2.7 December 15, 2024 10:29
@amiraabouhadid amiraabouhadid marked this pull request as ready for review December 15, 2024 10:30
0oM4R
0oM4R approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to rent a node, deploy vm ,and transfer tfts, all works fine without any weird logs

@samaradel
Copy link
Contributor

Works fine with me

@amiraabouhadid amiraabouhadid merged commit 0fb7121 into development_2.7 Dec 15, 2024
10 checks passed
@amiraabouhadid amiraabouhadid deleted the dev_2.7_logger_fix branch December 15, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R approved these changes

@samaradel samaradel samaradel approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@zaelgohary zaelgohary Awaiting requested review from zaelgohary

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amiraabouhadid @samaradel @0oM4R