Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance stats data #3728

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Enhance stats data #3728

merged 8 commits into from
Dec 9, 2024

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Dec 9, 2024

Description

  • reformat ssd result,
  • fix the fallback to main net url

Changes

  • refactor stats store to await for the monitor lock then fetch the stats data
  • format the stats ssd result to be like "1,000 GB"
  • update dummy data in cached script

Related Issues

Tested Scenarios

  • first build the stats image
  • run a container with image then access the container and check zinit log
  • check the container ip using inspect and call "<container_ip>/api/stats-summary
  • you should find the ssd result with vlaue like 1,800 GB

telegram-cloud-photo-size-4-5958317437667624236-y
image
image

dashboard

in public/config.js replace the STATS_STACKS value with [<stats_container_ip>]
run dashboard you should see the cards in landing page with the ssd value as mentioned before

also check the stats page in the dashboard and check the ssd card

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@maayarosama
Copy link
Contributor

you need to adjust this function too

@0oM4R
Copy link
Contributor Author

0oM4R commented Dec 9, 2024

you need to adjust this function too

done please check

@0oM4R 0oM4R force-pushed the development_stats branch from 4bb355e to 3a6d2b3 Compare December 9, 2024 13:40
@amiraabouhadid
Copy link
Contributor

is it alright if ssd values are not exactly the same?
image

@maayarosama
Copy link
Contributor

is it alright if ssd values are not exactly the same?

image

Are you sure you're using the container's ip in the playground?

@0oM4R
Copy link
Contributor Author

0oM4R commented Dec 9, 2024

is it alright if ssd values are not exactly the same? image

are sure that you applied the mentioned steps that related to dashboard section ?

dashboard

in public/config.js replace the STATS_STACKS value with [<stats_container_ip>]
run dashboard you should see the cards in landing page with the ssd value as mentioned before

also check the stats page in the dashboard and check the ssd card
dashboard

in public/config.js replace the STATS_STACKS value with [<stats_container_ip>]
run dashboard you should see the cards in landing page with the ssd value as mentioned before

also check the stats page in the dashboard and check the ssd card

Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works
image

@0oM4R 0oM4R merged commit 0c0f60a into development Dec 9, 2024
10 checks passed
@0oM4R 0oM4R deleted the development_stats branch December 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants