Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blocked bridge address in withdraw dialog #3705

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Fix blocked bridge address in withdraw dialog #3705

merged 3 commits into from
Dec 13, 2024

Conversation

amiraabouhadid
Copy link
Contributor

Changes

  • removed static blocked addresses strings, replaced with env var for bridge address
  • updated err msg explaining why address is blocked in validation

Related Issues

#3667

Tested Scenarios

  • took bridge address from deposit dialog and placed in withdraw dialog stellar wallet address, observed updated err msg, tested on devnet and qanet

Checklist

  • Screenshots/Video attached (needed for UI changes)
    image

@amiraabouhadid amiraabouhadid marked this pull request as ready for review December 3, 2024 08:45
@amiraabouhadid amiraabouhadid changed the base branch from development to development_2.7 December 3, 2024 08:45
@amiraabouhadid amiraabouhadid merged commit 5b0783c into development_2.7 Dec 13, 2024
10 checks passed
@amiraabouhadid amiraabouhadid deleted the development_2.7_modify_bridge_msg branch December 13, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@samaradel samaradel samaradel approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@zaelgohary zaelgohary Awaiting requested review from zaelgohary

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar

@0oM4R 0oM4R Awaiting requested review from 0oM4R

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amiraabouhadid @samaradel @maayarosama