Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change url for terms and conditions from threefold library to manual #3687

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from
Draft

change url for terms and conditions from threefold library to manual #3687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5a14ff
change url for terms and conditions from threefold library to manual
Mik-TF Nov 28, 2024
41b7c9a
update legal url from library to manual
Mik-TF Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/grid_client/src/modules/tfchain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ class TFChain implements blockchainInterface {
});
}
await (
await client.termsAndConditions.accept({ documentLink: "https://library.threefold.me/info/legal/#/" })
await client.termsAndConditions.accept({ documentLink: "https://manual.grid.tf/knowledge_base/legal/terms_conditions_all3.html" })
Mik-TF marked this conversation as resolved.
Show resolved Hide resolved
).apply();
const ret = await (await client.twins.create({ relay })).apply();
if (disconnect) await client.disconnect();
Expand Down
4 changes: 2 additions & 2 deletions packages/playground/src/weblets/profile_manager.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ function parseAcceptTermsImage(tempDiv: HTMLDivElement, url: string) {
}

function parseAcceptTermsLink(tempDiv: HTMLDivElement) {
const url = "https://library.threefold.me/info/legal#";
const url = "https://manual.grid.tf/knowledge_base/legal/terms_conditions_all3.html";
const linkElements = tempDiv.querySelectorAll("a");
linkElements.forEach(linkElement => {
const currentDomainMatch = linkElement.href.match(/^(https?:\/\/[^\\/]+)/);
Expand All @@ -873,7 +873,7 @@ function parseAcceptTermsLink(tempDiv: HTMLDivElement) {
watch(openAcceptTerms, async () => {
if (openAcceptTerms.value) {
try {
const url = "https://library.threefold.me/info/legal/";
const url = "https://manual.grid.tf/knowledge_base/legal/terms_conditions_all3.html";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wont work; i think we should have markdown file to be able to parse it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also looks like the host have cors error
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CORS error resolved, we may see the error as the current appends readme.md to the link, if you commented this part you will not face the cors error again, but the content will be shown as html file
image

const response = await fetch(url + "readme.md");
const mdContent = await response.text();
const parsedContent = marked.parse(mdContent);
Expand Down
Loading