Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app btns & QR code #3681

Merged
merged 15 commits into from
Dec 10, 2024
Merged

Update app btns & QR code #3681

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8b5a961
update src for playstore and app store imgs, move qrcode and playstor…
amiraabouhadid Nov 24, 2024
b0489e2
add light mode playstore btns
amiraabouhadid Nov 24, 2024
a4dec10
update google play img in light mode, remove links surrounding btns
amiraabouhadid Nov 25, 2024
f002516
use qrplaystore component in profile manager
amiraabouhadid Nov 25, 2024
9885150
remove light app store btns
amiraabouhadid Nov 27, 2024
73ceee0
remove unused img
amiraabouhadid Nov 27, 2024
b0496db
adjust google play store btn width
amiraabouhadid Dec 2, 2024
9281da3
enlarge google play btn
amiraabouhadid Dec 2, 2024
3e9ccb4
add qrplaystore component to twin page
amiraabouhadid Dec 2, 2024
3c327c0
Merge branch 'development_2.7' into development_2.7_fix_google_play_btn
amiraabouhadid Dec 2, 2024
908f758
pass msg above qr code as prop to qrplaystore component
amiraabouhadid Dec 2, 2024
5cac27a
use slot instead of v-html
amiraabouhadid Dec 2, 2024
3451519
remove msg prop
amiraabouhadid Dec 2, 2024
1030aa8
wrap slot in p
amiraabouhadid Dec 10, 2024
2e632f7
remove p wrapping from slot, move it around text
amiraabouhadid Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/playground/src/components/qr_play_store.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div class="d-flex flex-column text-center align-center">
<slot></slot>
<p><slot></slot></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we wrapping the slot itself? we should put the tag element on the slot content right ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the same

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my idea was if we need to reuse this component with another content inside the slot whatever the content is will be inside a p tag, anyways thank you and great work

<div class="d-flex justify-center py-2">
<QrcodeGenerator :data="props.qr" />
</div>
Expand Down
Loading