Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(deploymentList/Caprover): enhance deleting caprover deployment #3675

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Nov 24, 2024

Description

Refactor deleting Caprover deployment:
the old flow was pushing all workers to an array and delete them instance by instance

now we are using machines.delete to delete the deployment

Changes

  • add isCaprover prop to manage delete caprover deployment
  • remove the old logic

Related Issues

Tested Scenarios

  • create caprover deployment worker and leader and delete it from deployemnt list, check the contract list after few seconds to avoid delay conflect, all deployement contracts should be deleted
  • deploy multiple machines uisng gridClient script then delete one of them, should keep the other one ( this test to make sure no side effect because of the changes)

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@0oM4R 0oM4R merged commit 1677788 into development_2.7 Dec 2, 2024
10 checks passed
@0oM4R 0oM4R deleted the development_2.7_caproverlisting branch December 2, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants