Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Selenium tests to run against all environments #3663

Merged
merged 12 commits into from
Dec 3, 2024

Conversation

ramezsaeed
Copy link
Contributor

@ramezsaeed ramezsaeed commented Nov 20, 2024

Description

Selenium test automation for Dashboard

Changes

  • Fix homepage tests (8 tests)
  • fix the config and generated url to be able to run the tests on different env (dev, qa, test and main)
  • update the documentation

Tested Scenarios

testrun on github actions
A list of scenarios tried to match the deliverables

To consider

Preliminary Checks:

  • Does it completely address the issue linked?
  • What about edge cases?
  • Does it meet the specified acceptance criteria?
  • Are there any unintended side effects?
  • Does the PR adhere to the team's coding conventions, style guides, and best practices?
  • Does it integrate well with existing features?
  • Does it impact the overall performance of the application?
  • Are there any bottlenecks or slowdowns?
  • Has it been optimized for efficiency?
  • Has it been adequately tested with unit, integration, and end-to-end tests?
  • Are there any known defects or issues?
  • Is the code well-documented?
  • Are changes to documentation reflected in the code?

UI Checks:

  • If a UI design is provided/ does it follow it?
  • Does every button work?
  • Is the data displayed logical? Is it what you expected?
  • Does every validation work?
  • Does this interface feel intuitive?
  • What about slow network? Offline?
  • What if the gridproxy/graphql/chain is failing?
  • What would a first time user have a hard time navigating here?

Code Quality Checks:

  • Code formatted/linted? Are there unused imports? .. etc
  • Is there redundant/repeated code?
  • Are there conditionals that are always true or always false?
  • Can we write this more concisely?
  • Can we reuse this code? If yes, where?
  • Will the changes be easy to maintain and update in the future?
  • Can this code become too complex to understand for other devs?
  • Can this code cause future integration problems?

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@ramezsaeed ramezsaeed changed the title Dev selenium fix tests Fix Selenium tests to run against all environments Nov 20, 2024
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix codacy workflow errors

@khaledyoussef24
Copy link
Contributor

Codacy check still failing

@samaradel
Copy link
Contributor

work flow run fails IMG_20241202_172217_971.jpg

@ramezsaeed ramezsaeed merged commit 5bd5aee into development Dec 3, 2024
10 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the dev_selenium_fix_tests branch December 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants