Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the status of getNodeAvailability dynamic #3027

Closed
wants to merge 1 commit into from
Closed

Make the status of getNodeAvailability dynamic #3027

wants to merge 1 commit into from

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Jun 25, 2024 •
edited
Loading

Description

Make the status of getNodeAvailability dynamic, it was down even it's standby

Changes

image_2024-06-25_12-58-49

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

0oM4R
0oM4R reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

is that normal ? node is up, but it says it was up for 0 sec ?

@samaradel
Copy link
Contributor Author

I think it's just up from a second, @AhmedHanafy725 can you confirm?

@AhmedHanafy725
Copy link
Contributor

I think it's just up from a second, @AhmedHanafy725 can you confirm?

It wasn't up at all in the past seconds and just went up, is that the case?

@samaradel
Copy link
Contributor Author

I think it's just up from a second, @AhmedHanafy725 can you confirm?

It wasn't up at all in the past seconds and just went up, is that the case?

it's what I got too, @0oM4R can you check the same node again please?

@0oM4R
Copy link
Contributor

0oM4R commented Jun 26, 2024

I think it's just up from a second, @AhmedHanafy725 can you confirm?

It wasn't up at all in the past seconds and just went up, is that the case?

it's what I got too, @0oM4R can you check the same node again please?

@samaradel after about 1 hour
image

@0oM4R
Copy link
Contributor

0oM4R commented Jun 26, 2024

and for many other up nodes
image

@samaradel samaradel marked this pull request as draft June 27, 2024 12:49
Base automatically changed from development_2.6 to development July 2, 2024 12:42
@samaradel samaradel closed this Aug 20, 2024
@AhmedHanafy725 AhmedHanafy725 deleted the development_2.6_standby_nodes branch December 3, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R left review comments

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samaradel @AhmedHanafy725 @0oM4R