Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate the root file system when creating the deployment machine #3006

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Calculate the root file system when creating the deployment machine #3006

merged 2 commits into from
Jun 24, 2024

Conversation

Mahmoud-Emad
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad commented Jun 23, 2024 •
edited
Loading

Description

Calculate the root file system when creating the deployment machine

Changes

  • Created a new function called 'calculateRootFs' to calculate the size of the root file system based on the machine specs.
  • Created unit tests for the created function to ensure that no weird behavior happens during the calculation.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad
feat: Calculate the root file system when creating the deployment mac…
9cdba32 
…hine:

- Created a new function called 'calculateRootFs' to calculate the size of the root file system based on the machine specs.
- Created unit tests for the created function to ensure that no weird behavior happens during the calculation.
AhmedHanafy725
AhmedHanafy725 reviewed Jun 23, 2024
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use this method in the playground instead of having a duplicate for it?

packages/grid_client/src/helpers/root_fs.ts Outdated Show resolved Hide resolved
@Mahmoud-Emad
chore: Replaced the rootFS function with the GC:
077aa55 
- Removed the `rootFS` function/file.
- Updated the solutions with the newly implemented `calculateRootFileSystem`.
- Removed the un-needed debug logs.
- Docstring the newly implemented function.
@Mahmoud-Emad Mahmoud-Emad merged commit 734ae77 into development_2.6 Jun 24, 2024
4 checks passed
@Mahmoud-Emad Mahmoud-Emad deleted the development_2.6_calculate_rootFS branch June 24, 2024 13:29
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar

@0oM4R 0oM4R Awaiting requested review from 0oM4R

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Mahmoud-Emad @AhmedHanafy725 @maayarosama @xmonader