Improved styling and functionality of application cards display #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
Mahmoud-Emad
force-pushed
the
development_2.6_responsive_application_cards
branch
from
ca7ec09 to
1a19b4a
Compare
- Introduced a new component called 'ApplicationCards' to manage the display of application cards. - Implemented dynamic card height adjustment based on the tallest card to ensure consistent appearance. - Added functionality to detect the current viewport size (mobile or desktop) and adjust card heights accordingly for better responsiveness and user experience.
Mahmoud-Emad
force-pushed
the
development_2.6_responsive_application_cards
branch
from
1a19b4a to
59a53cb
Compare
samaradel
reviewed
Jun 23, 2024
amiraabouhadid
requested changes
Jun 23, 2024
- Dynamically set card heights based on the length of the tallest card to ensure a consistent layout. - Modify the flex system to make the 'md' view span the full width of the container for improved responsiveness and visual appeal.
maayarosama
approved these changes
Jun 24, 2024
|
@Mahmoud-Emad please fix merge conflicts |
0oM4R
reviewed
Jun 25, 2024
packages/playground/src/components/applications/ApplicationCards.vue
Outdated
Show resolved
Hide resolved
- Removed unnecessary flare field. - Optimized card style for large screens.
Done, fixed |
0oM4R
approved these changes
Jun 25, 2024
samaradel
approved these changes
Jun 25, 2024
amiraabouhadid
requested changes
Jun 25, 2024
- Removed the tallest Card concept. - Set a default height of 200 and fixed the responsiveness. - Removed the mobile view checker.
Mahmoud-Emad
force-pushed
the
development_2.6_responsive_application_cards
branch
from
4bcbaa2 to
6e5c58f
Compare
amiraabouhadid
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved styling and functionality of application cards display
Changes
Related Issues
Screenshots/Video
Checklist