Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPs chip style #2992

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Fix IPs chip style #2992

merged 3 commits into from
Jun 23, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Jun 19, 2024 •
edited
Loading

Description

  • Add margin right to each chip
  • Use chip group in manage ssh

image

image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@maayarosama
Copy link
Contributor

it seems that the chips are clickable, does this affect the ips getting deleted?
Peek 2024-06-19 12-19

@zaelgohary
Copy link
Contributor Author

zaelgohary commented Jun 19, 2024 •
edited
Loading

it seems that the chips are clickable, does this affect the ips getting deleted?

You're right. I removed the chip ground and added margin.

@zaelgohary zaelgohary changed the title Use chip group in delete public IP Fix IPs chip style Jun 19, 2024
@zaelgohary zaelgohary marked this pull request as draft June 19, 2024 10:21
@zaelgohary zaelgohary marked this pull request as ready for review June 23, 2024 08:36
amiraabouhadid
amiraabouhadid approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@zaelgohary zaelgohary merged commit 7ef8313 into development_2.6 Jun 23, 2024
4 checks passed
@zaelgohary zaelgohary deleted the development_2.6_chip_group branch June 23, 2024 11:01
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar

@0oM4R 0oM4R Awaiting requested review from 0oM4R

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zaelgohary @maayarosama @amiraabouhadid @Mahmoud-Emad @xmonader