Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit additional fee err msg #2970

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Edit additional fee err msg #2970

merged 2 commits into from
Jun 13, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Jun 12, 2024 •
edited
Loading

Description

  • Edit err msg if node has active contract

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Mahmoud-Emad
Mahmoud-Emad requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Zainab :)

packages/playground/src/dashboard/components/set_extra_fee.vue Outdated Show resolved Hide resolved
@zaelgohary @Mahmoud-Emad
Fix typo
2ee9c0f 
Co-authored-by: Thunder <[email protected]>
@zaelgohary zaelgohary requested a review from Mahmoud-Emad June 13, 2024 06:46
@zaelgohary zaelgohary merged commit 0d985de into development_2.6 Jun 13, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_2.6_edit_err_msg branch June 13, 2024 08:49
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@samaradel samaradel samaradel approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar

@0oM4R 0oM4R Awaiting requested review from 0oM4R

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zaelgohary @samaradel @Mahmoud-Emad @maayarosama @xmonader