Apply filters in Node Finder on enter #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaelgohary
requested review from
AhmedHanafy725,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
maayarosama
approved these changes
Jun 9, 2024
|
Please attach a video of the change |
packages/playground/src/components/filters/TfFiltersContainer.vue
Outdated
Show resolved
Hide resolved
zaelgohary
changed the title
amiraabouhadid
previously approved these changes
Jun 10, 2024
amiraabouhadid
previously requested changes
Jun 10, 2024
There was a problem hiding this comment.
when i toggle gpu and press enter filter isnt applied
https://www.loom.com/share/b9ebddf09b78483284485fd0606daf50?sid=65474f3e-4857-458d-85cb-8bc841021735
MohamedElmdary
approved these changes
Jun 11, 2024
nice catch !! |
|
@zaelgohary after checking @amiraabouhadid comment I notice that using <VForm :disabled="loading" v-show="!collapsible || filterOpened" @keyup.enter="!valid || !changed ? undefined : apply()"> |
…grid-sdk-ts into development_2.6_filter_node_on_enter
MohamedElmdary
approved these changes
Jun 12, 2024
Mahmoud-Emad
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist