Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better log(aka. message) formatting #2891

Draft
wants to merge 8 commits into
base: development
Choose a base branch
from

Conversation

MohamedElmdary
Copy link
Member

@MohamedElmdary MohamedElmdary commented Jun 6, 2024

Note

This PR includes the component which format error but not yet used anywhere

Description

better error formating

Changes

error-format.mov

Usage

<TfLogFormatter :msg="'some string message'"/>

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary MohamedElmdary self-assigned this Jun 6, 2024
@MohamedElmdary MohamedElmdary changed the title Better error formating Better log(aka. message) formating Sep 4, 2024
@MohamedElmdary MohamedElmdary changed the title Better log(aka. message) formating Better log(aka. message) formatting Sep 4, 2024
@MohamedElmdary MohamedElmdary marked this pull request as ready for review September 4, 2024 09:37
@amiraabouhadid
Copy link
Contributor

It doesn't look that user friendly to me to be honest @ehab-hassan, what do you think?

@ehab-hassan
Copy link
Contributor

It doesn't look that user friendly to me to be honest @ehab-hassan, what do you think?

It shows the main error message then if the user needs more info he clicks to expand, can you explain more about what it is not friendly to you?

@0oM4R
Copy link
Contributor

0oM4R commented Sep 12, 2024

I suggest putting this great feature on the logger instead

@amiraabouhadid
Copy link
Contributor

It doesn't look that user friendly to me to be honest @ehab-hassan, what do you think?

It shows the main error message then if the user needs more info he clicks to expand, can you explain more about what it is not friendly to you?

Might look strange to a user not familiar with json format. But if you approve, then it's alright by me.

@ehab-hassan
Copy link
Contributor

ehab-hassan commented Sep 16, 2024

@MohamedElmdary can we make it as Expansion panel?

@zaelgohary zaelgohary marked this pull request as draft September 19, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants