Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate wallet connector extension #1785

Draft
wants to merge 35 commits into
base: development
Choose a base branch
from
Draft

Integrate wallet connector extension #1785

wants to merge 35 commits into from

Conversation

MohamedElmdary
Copy link
Member

@MohamedElmdary MohamedElmdary commented Dec 24, 2023 •
edited
Loading

Note: The naming for that component changed
- Old: Profile Manager
+ Current: Wallet Connector

Description

It's require to integrate wallet connector extension into playground while letting the old flow as it is so users are free to use extension or old flow

Video Showing User Flow

Changes

  • Rename profile manager to wallet connector
  • Rewrite wallet connector from scratch using newly introduced hooks (useSession, useLocalStorage, useAsync, ...etc)
  • Remove all profile manager related files (profile_manager.vue, profile_manager_controller.vue)
  • Introduce a way to provide a global service by injecting app while initializing (useApp)
  • Provide WalletService to allow interacting with wallet connector (e.g reloadBalance, toggle open, ...etc)
  • Improve ux/ui
  • Improve flex layout it became way solid now
  • Prevent ui from getting destroied when dialog gets closed (less rerender - better performance)
  • Introduce animations (vuetify standard)
Before After
image image
image image
image image
image image
image image
image image
image image
image image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary
feat: add wallet connector layout and break it's parts into components
936dc67
@MohamedElmdary
feat: add style of logged in wallet
d3445e1
@MohamedElmdary
feat: add helper hooks to manage localstorage and session storage
ff5f646
@MohamedElmdary
feat: add register page with full validation functions
7121ba6
@MohamedElmdary
refactor: use text/v-text instead of slots in possible positions
47df319
@MohamedElmdary
add extension login ui
96dbe99
@MohamedElmdary
style: fix some bad styles and improve message errors
d50cff4
@MohamedElmdary
fix: connect app parts using services
6d32148
@MohamedElmdary
moved main login/logout functions into main component
2132a2c
@MohamedElmdary
chore: Merge branch 'development' into development_integrate_wallet_c…
a174f59 
…onnector
@MohamedElmdary
feat: add login with extension and add login profile details
2e9977e
@MohamedElmdary
refactor: clean code a little and fix focus issue
9a8d984
@MohamedElmdary
Merge branch 'development' into development_integrate_wallet_connector
f2acaec
@MohamedElmdary
feat: add apps and qrcode
3e5523e
@MohamedElmdary
feat: disabled inputs while loading
f018d51
@MohamedElmdary
feat: don't update balance if failed to get it for 5 times
0191f4c
@MohamedElmdary
feat: add/remove login tab based on credentials existance
a6ff368
@MohamedElmdary
Merge branch 'development' into development_integrate_wallet_connector
c107d84
@MohamedElmdary
feat: add create/activate account and accepting terms and conditions
93450d4
@MohamedElmdary MohamedElmdary self-assigned this Dec 24, 2023
@MohamedElmdary MohamedElmdary marked this pull request as draft December 24, 2023 22:32
@MohamedElmdary
- fix: handle disable/enable button while update/generate ssh
84d2474 
- fix: disable logout buttons if user storing/updating ssh
- feat: expose walletService to allow open profileManager from outside
@MohamedElmdary MohamedElmdary changed the title Development integrate wallet connector Integrate wallet connector extension Dec 25, 2023
@MohamedElmdary MohamedElmdary added type_feature New feature or request playground labels Dec 25, 2023
@MohamedElmdary MohamedElmdary marked this pull request as ready for review December 25, 2023 11:28
mohamedamer453
mohamedamer453 reviewed Dec 31, 2023
View reviewed changes
Copy link
Contributor

@mohamedamer453 mohamedamer453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts

mohamedamer453
mohamedamer453 reviewed Dec 31, 2023
View reviewed changes
Copy link
Contributor

@mohamedamer453 mohamedamer453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohamedElmdary MohamedElmdary marked this pull request as draft February 5, 2024 12:12
@MohamedElmdary
chore: Merge branch 'development' into development_integrate_wallet_c…
6344faa 
…onnector
@MohamedElmdary
- chore: disable tf wallet connector extension for now
ea22a5b 
- feat: Add newly added features in current implementation of profile manager
- fix: types state/Igrid was causing issues as they were not exported
@MohamedElmdary
fix: using balance from walletService instead of old way
a836c14
@MohamedElmdary
fix: build was failling due to using old profile manager instead of n…
ca54a57 
…ew wallet service
@MohamedElmdary MohamedElmdary marked this pull request as ready for review March 27, 2024 12:18
@MohamedElmdary MohamedElmdary marked this pull request as draft April 15, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedamer453 mohamedamer453 mohamedamer453 left review comments

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@MohamedElmdary MohamedElmdary

Labels
playground type_feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MohamedElmdary @mohamedamer453