Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix time in Loading deployments main net. #1278

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Fix time in Loading deployments main net. #1278

merged 6 commits into from
Oct 26, 2023

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented Oct 25, 2023 •
edited
Loading

image

  • If failed

image
image

  • In case the node is not reachable

image
image

  • same for k8s

image

image

@zaelgohary
Copy link
Contributor

zaelgohary commented Oct 25, 2023 •
edited
Loading

I was able to show the error without throttling my network.

image

The warning is misleading as we couldn't show the deployment because we sat a timeout before retrieving the response. Not sure if this is the best solution as I don't think we should show an error to the user instead of waiting a bit more.

@AlaaElattar
Copy link
Contributor Author

image

image

@xmonader xmonader merged commit cc8dbfe into development Oct 26, 2023
3 checks passed
@xmonader xmonader deleted the development_load_vm_main branch October 26, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmonader xmonader xmonader approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlaaElattar @zaelgohary @xmonader