-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ping node utils and update tests #1258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a pingNode function available on the client
async pingNode(options: PingNodeOptionsModel): Promise<boolean> { |
P.S don't name functions checkNodeAvail
it's incomplete and doesn't communicate the meaning
I'm using pingNode function to check node state and return its ID. Updated function name 30e3cb2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Add the Ping node function in utils to check every node that will be used in the tests before using it, preventing false-failing tests.