Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ping node utils and update tests #1258

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

A-Harby
Copy link
Contributor

@A-Harby A-Harby commented Oct 22, 2023

Description

Add the Ping node function in utils to check every node that will be used in the tests before using it, preventing false-failing tests.

Copy link
Contributor

@xmonader xmonader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a pingNode function available on the client

async pingNode(options: PingNodeOptionsModel): Promise<boolean> {

P.S don't name functions checkNodeAvail it's incomplete and doesn't communicate the meaning

@A-Harby
Copy link
Contributor Author

A-Harby commented Oct 23, 2023

there's a pingNode function available on the client

async pingNode(options: PingNodeOptionsModel): Promise<boolean> {

P.S don't name functions checkNodeAvail it's incomplete and doesn't communicate the meaning

I'm using pingNode function to check node state and return its ID.

Updated function name 30e3cb2

@A-Harby A-Harby requested a review from xmonader October 23, 2023 07:40
Copy link
Contributor

@mohamedamer453 mohamedamer453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, and i ran the tests locally and everything went smoothly and passed.

image

@AhmedHanafy725 AhmedHanafy725 merged commit 1bf02c4 into development Nov 16, 2023
2 of 4 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_add_pingNode_tests branch November 16, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants