Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats website in vue3 #1234

Merged
merged 40 commits into from
Oct 29, 2023
Merged

Stats website in vue3 #1234

merged 40 commits into from
Oct 29, 2023

Conversation

0oM4R
Copy link
Contributor

@0oM4R 0oM4R commented Oct 17, 2023 •
edited
Loading

Description

New stats website using Vue3
this website is similar to the old stats website but i will mention some of the new features

  • support standby nodes stats

  • network filter

    • The user can select one or more networks to get their stats
      Screenshot from 2023-10-23 17-40-30

      • if the user tried to switch off all toggles will got a warning dialog
        Screenshot from 2023-10-24 11-22-12

      • the website will make a request to get a network stats only if the user click on refresh button and on mount

  • responsive
    image

  • loading error

image

Changes

List of changes this PR includes

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@0oM4R 0oM4R changed the base branch from development to development_313 October 17, 2023 14:20
@0oM4R 0oM4R added the stats label Oct 18, 2023
@0oM4R 0oM4R mentioned this pull request Oct 24, 2023
Closed
@zaelgohary
Copy link
Contributor

Can we change the card size in the responsive view. It's not normal for the card to be bigger than the map. You can check with @ehab-hassan for a better view.

image

@ehab-hassan
Copy link
Contributor

ehab-hassan commented Oct 25, 2023 •
edited
Loading

@zaelgohary agree with you, but the problem in the map, it need to be more flexible and can zoom in and out on it ,I checked wih Rabie and he said that he ll look for another map in future, ll create issue about that.

@0oM4R 0oM4R requested a review from maayarosama October 25, 2023 13:05
@maayarosama maayarosama mentioned this pull request Oct 25, 2023
Closed
@0oM4R 0oM4R marked this pull request as draft October 26, 2023 08:23
@0oM4R 0oM4R marked this pull request as ready for review October 26, 2023 10:02
@0oM4R 0oM4R mentioned this pull request Oct 26, 2023
Closed
zaelgohary
zaelgohary reviewed Oct 29, 2023
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Some comments on packages that are not used like cypress & vitest. There aren't any tests written for those so I don't think both are necessary for atm.

packages/new_stats/README.md
You can now run the project in development mode using

```bash
yarn workspace newstats dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call the workspace newstats? I think this would be the default stats and the old one will be archived once this is merged and released.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will keep this name till we phase out the old stats

packages/new_stats/cypress.config.ts Outdated Show resolved Hide resolved
packages/new_stats/cypress/fixtures/example.json Outdated Show resolved Hide resolved
packages/new_stats/cypress/support/commands.ts Outdated Show resolved Hide resolved
packages/new_stats/cypress/support/e2e.ts Outdated Show resolved Hide resolved
packages/new_stats/package.json Show resolved Hide resolved
packages/new_stats/src/components/stats_table.vue Outdated Show resolved Hide resolved
packages/new_stats/src/components/stats_table.vue Show resolved Hide resolved
packages/new_stats/README.md Outdated Show resolved Hide resolved
@0oM4R 0oM4R requested a review from zaelgohary October 29, 2023 12:11
zaelgohary
zaelgohary requested changes Oct 29, 2023
View reviewed changes
packages/new_stats/package.json Show resolved Hide resolved
packages/new_stats/vitest.config.ts Show resolved Hide resolved
packages/new_stats/tsconfig.vitest.json Show resolved Hide resolved
@0oM4R 0oM4R requested a review from zaelgohary October 29, 2023 13:40
@0oM4R 0oM4R merged commit 5c01306 into development_313 Oct 29, 2023
@0oM4R 0oM4R deleted the development_313_stats branch October 29, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
stats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0oM4R @zaelgohary @ehab-hassan @maayarosama