Fix Bug in pricing calculator #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlaaElattar
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid and
Omarabdul3ziz
as code owners
|
|
zaelgohary
reviewed
Oct 18, 2023
zaelgohary
requested changes
Oct 18, 2023
zaelgohary
approved these changes
Oct 18, 2023
| @@ -237,7 +242,6 @@ watch([CRU, MRU, SRU, HRU, balance, isCertified, ipv4, currentbalance], async () | |||
| sru: SRU.value, | |||
| ipv4u: ipv4.value, | |||
| certified: isCertified.value, | |||
| balance: balance.value, | |||
There was a problem hiding this comment.
now if I try to enter any balance check how much discount will get for this balance, it won't work
IMO, we should disable the balance text field if the switch is enabled without changing the current balance.
There was a problem hiding this comment.
- Fixed
video1956433406.mp4
|
maayarosama
approved these changes
Oct 19, 2023
AhmedHanafy725
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
video1236143077.mp4