Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor #1188

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix editor #1188

merged 2 commits into from
Oct 9, 2023

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Oct 9, 2023 •
edited
Loading

Description

  • The hashes did not match, that's why it gave an error when verifying.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Mahmoud-Emad
Mahmoud-Emad reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I've added just a small comment, kindly take a look at it.

packages/UI/examples/server-example/src/server.ts Outdated Show resolved Hide resolved
@zaelgohary zaelgohary merged commit 05efc8e into development Oct 9, 2023
3 checks passed
@zaelgohary zaelgohary deleted the development_fix_editor branch October 9, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaelgohary @Mahmoud-Emad