Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all toasts compatible #1153

Merged
merged 11 commits into from
Oct 9, 2023
Merged

Make all toasts compatible #1153

merged 11 commits into from
Oct 9, 2023

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented Sep 26, 2023 •
edited
Loading

@AlaaElattar AlaaElattar changed the base branch from development to development_313 September 26, 2023 14:45
AhmedHanafy725
AhmedHanafy725 reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure to use this color #FF5252 for error ones and #1aa18f for success ones

@0oM4R
Copy link
Contributor

0oM4R commented Oct 2, 2023

I believe we can handle the spaces here to make it aligned, specially the icon
image

@0oM4R
Copy link
Contributor

0oM4R commented Oct 2, 2023

also the failed toast
image

@AlaaElattar AlaaElattar marked this pull request as draft October 2, 2023 14:14
@AlaaElattar AlaaElattar marked this pull request as ready for review October 5, 2023 14:45
@AlaaElattar
Copy link
Contributor Author

  • The user will only choose type from predefined ones and add message without considering anything else

AhmedHanafy725
AhmedHanafy725 reviewed Oct 8, 2023
View reviewed changes
packages/playground/src/components/tf_notification.vue Outdated Show resolved Hide resolved
packages/playground/src/components/custom_toast.vue Outdated Show resolved Hide resolved
packages/playground/src/components/custom_toast.vue Outdated
Comment on lines 4 to 7
const typeToColor: { [key: string]: string } = {
success: "#1aa18f",
danger: "#FF5252",
info: "#1aa18f",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehab-hassan can you check the colors here for the toast and provide colors for the missing ones?

the supported types: danger, default, info, success, and warning

Copy link
Contributor

@ehab-hassan ehab-hassan Oct 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frame 257 (1)

Default #313131

Success #1AA18F

Info #2196F3

Warning #FFCC00

Danger #FF5252

  • keep the space between the icon and text smaller.
  • Make text Capitalise.
  • Font 14px or 0.875rem

Copy link
Contributor Author

@AlaaElattar AlaaElattar Oct 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All applied but i feel that text is too small compared to the whole page.

Screenshot from 2023-10-09 12-44-03

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font is clear to me and readable no need to make it bigger

@AlaaElattar AlaaElattar marked this pull request as draft October 8, 2023 12:51
@AlaaElattar AlaaElattar marked this pull request as ready for review October 9, 2023 09:53
@AhmedHanafy725 AhmedHanafy725 merged commit e9b5400 into development_313 Oct 9, 2023
@AhmedHanafy725 AhmedHanafy725 deleted the development_313_update_toast branch October 9, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehab-hassan ehab-hassan ehab-hassan left review comments

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlaaElattar @0oM4R @ehab-hassan @AhmedHanafy725