Skip to content

Commit

Permalink
Fix typos and update texts
Browse files Browse the repository at this point in the history
  • Loading branch information
MohamedElmdary committed Oct 24, 2023
1 parent e405726 commit 5b8053a
Showing 1 changed file with 9 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Done

## Context

Previously we didn't have a way to tell that this gateway related to that deployment. So we decided to make some updates will be listed below in order to being able to group all deployment related stuff in a single path treating path as a folder.
Previously we didn't have a way to tell that a gateway is related to a certain virtual machine. So we decided to make some updates will be listed below in order to be able to group all deployments' workloads in a similar path hierarchy.

e.g

Expand All @@ -31,16 +31,17 @@ tfchain

1. For old deployments

- We added a migration script will be ablied whenever the user tries to list his own deployments
- Migratable deployments will be getting an update in it's contracts data (if needed)
- Migration will applied once for each contract (Write new contract data then remove the old one)
- We added a migration script will be applied whenever the user tries to list his own deployments
- Migrated deployments will be getting an update in their contracts' data (if needed)
- Migrating the contracts is done by only one request to update the contract.
- Keys stored on the kvstore on tfchain are migrated by creating a new key and removing the old one.

2. For new deployments
- Updated projectName to match the new pattern for a deployment called `testvm` in projectName called `vm` the new projectName will be `vm/testvm` instead of `vm`.
- The projectName has been updated to match the new pattern for the deployment. For example, if the deployment is called `testvm` in the projectName called `vm` the new projectName will be `vm/testvm` instead of `vm`.
- Gateways will be stored in the same previous projectName pattern mentioned above.
- Listing will follow the same pattern. After listing all deployments related to a specific projectName (e.g `p1`) let's say we get deployment as follow `[d1, d2]` so we will load deployment of `p1/d1` & `p1/d2` in playground.
- For kubernetes it doesn't use any projectName so the projectName will be the instanceName itself.
- Listing will follow the same pattern. After listing all deployments related to a specific projectName (e.g `p1`) let's say we got deployments `[d1, d2]` so we will load the deployment of `d1` from the projectName `p1/d1` and the deployment `d2` is the same in the playground.
- For Kubernetes, it doesn't use any projectName so the projectName will be the instanceName itself.

## Consequences

There is no specific consquences related to this issue but an issue appeared <a target="_blank" href="https://github.com/threefoldtech/tfchain_graphql/issues/135">tfchain_graphql#135</a>.
There is no specific consequences related.

0 comments on commit 5b8053a

Please sign in to comment.