use zos3 nodes if not enough zos4 nodes were found #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
requested review from
MarioBassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader and
sameh-farouk
as code owners
rawdaGastan
approved these changes
Nov 5, 2024
Eslam-Nawara
force-pushed
the
development-tfrobot-use-zos3-node-if-no-zosa4-nodes-found
branch
from
5100678 to
6506358
Compare
rawdaGastan
reviewed
Nov 5, 2024
| disks, diskMounts := parseDisks(vmName, vmGroup.SSDDisks) | ||
| volumes, volumeMounts := parseVolumes(vmName, vmGroup.Volumes) | ||
|
|
||
| deployment := workloads.NewDeployment("", nodeID, solutionType, nil, networkName, disks, nil, nil, nil, nil, volumes) | ||
|
|
||
| if !vmGroup.WireGuard && !vmGroup.PublicIP4 && !vmGroup.PublicIP6 && !vmGroup.Ygg { | ||
| if isLight { |
There was a problem hiding this comment.
I think here we missed public ips check
There was a problem hiding this comment.
it's already tested in the filtration here
rawdaGastan
approved these changes
Nov 5, 2024
Eslam-Nawara
deleted the
development-tfrobot-use-zos3-node-if-no-zosa4-nodes-found
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use zos3 nodes if not enough zos4 nodes were found
Changes
use zos3 nodes if not enough zos4 nodes were found
Related Issues
Checklist