Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development support deploying k8s workers on multiple nodes #1136

Merged
merged 20 commits into from
Aug 1, 2024
Merged

Development support deploying k8s workers on multiple nodes #1136

merged 20 commits into from
Aug 1, 2024

Conversation

Nabil-Salah
Copy link
Contributor

@Nabil-Salah Nabil-Salah commented Jul 30, 2024 •
edited
Loading

Description

Make workers deploy on multiple nodes.

changes

List of changes this PR includes

  • grid cli
    • added the option flag to specify nodes workers can work on

Related Issues

List of related issues

Eslam-Nawara
Eslam-Nawara requested changes Jul 30, 2024
View reviewed changes
grid-cli/cmd/deploy_kubernetes.go Outdated Show resolved Hide resolved
grid-cli/cmd/deploy_kubernetes.go Show resolved Hide resolved
@Nabil-Salah Nabil-Salah requested a review from Eslam-Nawara July 30, 2024 11:16
@Nabil-Salah Nabil-Salah requested a review from Eslam-Nawara July 30, 2024 13:27
@Nabil-Salah Nabil-Salah self-assigned this Jul 31, 2024
@Nabil-Salah Nabil-Salah added type_feature New feature or request grid-cli belongs to grid cli labels Jul 31, 2024
@Nabil-Salah Nabil-Salah added this to the v0.16.0 milestone Jul 31, 2024
@xmonader xmonader changed the title Development support deploying k8s workers on multible nodes Development support deploying k8s workers on multiple nodes Aug 1, 2024
@Eslam-Nawara Eslam-Nawara merged commit 0cccf8c into development Aug 1, 2024
39 checks passed
@Eslam-Nawara Eslam-Nawara deleted the development-support-deploying-k8s-workers-on-multible-nodes branch August 1, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eslam-Nawara Eslam-Nawara Eslam-Nawara approved these changes

@muhamadazmy muhamadazmy Awaiting requested review from muhamadazmy

@MarioBassem MarioBassem Awaiting requested review from MarioBassem MarioBassem is a code owner

@ashraffouda ashraffouda Awaiting requested review from ashraffouda ashraffouda is a code owner

@rawdaGastan rawdaGastan Awaiting requested review from rawdaGastan rawdaGastan is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz Omarabdul3ziz is a code owner

@xmonader xmonader Awaiting requested review from xmonader xmonader is a code owner

@sameh-farouk sameh-farouk Awaiting requested review from sameh-farouk sameh-farouk is a code owner

@AbdelrahmanElawady AbdelrahmanElawady Awaiting requested review from AbdelrahmanElawady AbdelrahmanElawady is a code owner

Assignees
No one assigned
Labels
grid-cli belongs to grid cli type_feature New feature or request
Projects
None yet
Milestone
v0.16.x
Development

Successfully merging this pull request may close these issues.
3 participants
@Nabil-Salah @AbdelrahmanElawady @Eslam-Nawara