Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor idenfy client to use net/http instead of fasthttp #18

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Refactor idenfy client to use net/http instead of fasthttp #18

merged 2 commits into from
Nov 12, 2024

Conversation

sameh-farouk
Copy link
Member

@sameh-farouk sameh-farouk commented Nov 10, 2024 •
edited
Loading

Changes:

  • Refactoring the logic into smaller functions
  • switch to the default HTTP client instead of fastHttp

Related Issues:

Notes: To be followed with more work to evaluate/switch from Go Fiber framework to a more mature solution per @xmonader request

@sameh-farouk sameh-farouk marked this pull request as ready for review November 11, 2024 23:03
Omarabdul3ziz
Omarabdul3ziz approved these changes Nov 12, 2024
View reviewed changes
Copy link

@Omarabdul3ziz Omarabdul3ziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, i just had a small comment about refactoring the server that uses fiber, and sameh mentioned this is addressed in another issue.

since we don't use fasthttp pkg anymore we could remove it from the mod file

@sameh-farouk sameh-farouk merged commit d9040bf into development Nov 12, 2024
@sameh-farouk sameh-farouk deleted the development-refactor-idenfy-client branch November 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Omarabdul3ziz Omarabdul3ziz Omarabdul3ziz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to default HTTP client instead of fasthttp
2 participants
@sameh-farouk @Omarabdul3ziz