Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to default HTTP client instead of fasthttp #8

Open
xmonader opened this issue Nov 7, 2024 · 1 comment · Fixed by #18
Open

Switch to default HTTP client instead of fasthttp #8

xmonader opened this issue Nov 7, 2024 · 1 comment · Fixed by #18
Assignees
Milestone

Comments

@xmonader
Copy link
Contributor

xmonader commented Nov 7, 2024

Why? https://github.com/valyala/fasthttp#faq

Are there known net/http advantages comparing to fasthttp?

Yes:

net/http supports HTTP/2.0 starting from go1.6.
net/http API is stable, while fasthttp API constantly evolves.
net/http handles more HTTP corner cases.
net/http can stream both request and response bodies
net/http can handle bigger bodies as it doesn't read the whole body into memory
net/http should contain less bugs, since it is used and tested by much wider audience.

Originally posted by @xmonader in #4 (comment)

@sameh-farouk
Copy link
Member

Update:
PR ready for review

@sameh-farouk sameh-farouk moved this from In Progress to Pending Deployment in 3.15.x Nov 11, 2024
@sameh-farouk sameh-farouk moved this from Pending Deployment to Pending Review in 3.15.x Nov 11, 2024
@github-project-automation github-project-automation bot moved this from Pending Review to Done in 3.15.x Nov 12, 2024
@sameh-farouk sameh-farouk moved this from Done to Pending Deployment in 3.15.x Nov 12, 2024
@sameh-farouk sameh-farouk reopened this Nov 12, 2024
@sameh-farouk sameh-farouk moved this from Pending Deployment to In Verification in 3.15.x Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Verification
Development

Successfully merging a pull request may close this issue.

2 participants