Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook endpoint: Handle doc expiration #11

Closed
xmonader opened this issue Nov 7, 2024 · 5 comments
Closed

Webhook endpoint: Handle doc expiration #11

xmonader opened this issue Nov 7, 2024 · 5 comments
Assignees
Milestone

Comments

@xmonader
Copy link
Contributor

xmonader commented Nov 7, 2024

No description provided.

@xmonader xmonader added this to the 0.2.x milestone Nov 7, 2024
@sameh-farouk sameh-farouk moved this to Accepted in 3.15.x Nov 10, 2024
@sameh-farouk sameh-farouk moved this from Accepted to In Progress in 3.15.x Nov 10, 2024
@sameh-farouk sameh-farouk self-assigned this Nov 10, 2024
@sameh-farouk
Copy link
Member

The feature is coded but blocked on https://github.com/threefoldtech/tf_operations/issues/2902 since I can't run the code and verify its functionality.

@sameh-farouk sameh-farouk moved this from In Progress to Blocked in 3.15.x Nov 10, 2024
@xmonader xmonader moved this from Blocked to In Progress in 3.15.x Nov 11, 2024
@xmonader
Copy link
Contributor Author

Should go back to in progress

@sameh-farouk
Copy link
Member

Update:
PR ready to review

@sameh-farouk sameh-farouk moved this from In Progress to Pending Review in 3.15.x Nov 11, 2024
@sameh-farouk sameh-farouk moved this from Pending Review to Pending Deployment in 3.15.x Nov 12, 2024
@sameh-farouk sameh-farouk moved this from Pending Deployment to In Verification in 3.15.x Nov 13, 2024
@sameh-farouk
Copy link
Member

sameh-farouk commented Nov 25, 2024

Update:
The feature functions properly in environments where we have one instance per backend, such as in DevNet and QANet. However, in TestNet and MainNet, the document expiry notifications for clients on both networks are sent to only one instance, despite our attempts to override the callback URL during the creation of the verification session.

Idenfy's response:

After consulting with the technical team regarding the inquiry, it has been confirmed that the Document expiry notification will not be overwritten by callbackUrl. That parameter only impacts ID verification responses and events - auto and manual review, expiration, cancellation.

This handler needs to be revised, but it should not rely on webhooks anymore. see #24

@sameh-farouk
Copy link
Member

Closed in favor of #24.

@github-project-automation github-project-automation bot moved this from In Verification to Done in 3.15.x Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants