Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a stat for number of BUILD files currently parsing #3290

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

peterebden
Copy link
Collaborator

@peterebden peterebden commented Nov 8, 2024

We've seen a few cases recently of plz apparently hanging. It's unclear precisely what's going on (the version hasn't changed for some time yet the issues seem recent).

This should help shed a little light on what it's doing. I think it's not a bad stat to see in general.

I decided just to expose the atomic.Int64 object directly, could also wrap it in several functions if needed but I don't think it helps especially. Would be easy enough to change later.

Output looks like this:

09:57:47.482  NOTICE: Build running for 40s, 41405 / 82029 tasks done, 250 workers busy, parsing 22584 BUILD files
09:57:57.481  NOTICE: Build running for 50s, 59727 / 101290 tasks done, 250 workers busy, parsing 19236 BUILD files
09:58:07.481  NOTICE: Build running for 1m0s, 88643 / 117338 tasks done, 250 workers busy, parsing 4390 BUILD files

@peterebden peterebden merged commit 83e0243 into thought-machine:master Nov 8, 2024
14 checks passed
@peterebden peterebden deleted the add-parsing-stat branch November 8, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants