Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output target display not have local targets hanging around so much #3276

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

peterebden
Copy link
Collaborator

This is split out from another PR I'm working on, to try to keep that one a bit more sane.

What I'm observing is that while I have local build actions running at a fair pace, with remote execution online but being underutilised, the display shows a lot more local actions than I'd expect. It isn't actually executing them, just showing their 'shadow' for a few seconds.

This happens because the display is using a common set of 'slots' for them which is shared between both. This changes it so each has its own set of 'available slots' that are not shared. The eventual result is that you see a few local actions at the top of the list, to a max of the number of local workers that are configured, with all the remote ones beneath them.

This is what was intended all along but it wasn't quite doing it; I don't think we have anywhere where we'd really observe it right now, you'd need something like remote execution enabled with a whole bunch of actions with local = True on them (we have no such actions internally, it's been a requirement that everything supports remote execution for a few years now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants