Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've discussed this quite a bit internally, it has several advantages over the current setup:
MIT AND Zlib
, but these have to be accepted as though they were a licence in their own right; fortunately they aren't common but we shouldn't have to accept every permutation separately.I am slightly worried that the SPDX library is stricter about licence identifiers. I've had to adjust the behaviour a bit so it will pass licences that are not on the list as-is, but they do still need to be structurally valid (i.e.
MPL-2.0
notThe Mozilla Public License, version 2.0 (with Chocolate Coating)
). I don't particularly want to maintain a completely separate implementation internally with the old list-based thing though.This also deprecates the
add_licence
andget_licences
builtins in favour of new ones,get_licence
andset_licence
which operate just on a single string.