Introduce puku and sync go.mod #2977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatskaari
force-pushed
the
introduce-puku
branch
from
5429975 to
f9a539b
Compare
Tatskaari
commented
Nov 26, 2023
| @@ -30,7 +38,7 @@ func parseGoTestResults(data []byte) (core.TestSuite, error) { | |||
| suite := core.TestSuite{ | |||
| Package: pkg.Name, | |||
| Duration: pkg.Duration, | |||
| Properties: pkg.Properties, | |||
| Properties: propertiesToMap(pkg.Properties), | |||
Tatskaari
commented
Nov 26, 2023
Comment on lines
404
to
408
| go_repo( | ||
| licences = ["ISC"], | ||
| module = "github.com/davecgh/go-spew", | ||
| version = "v1.1.1", | ||
| ) |
There was a problem hiding this comment.
Looks like we weren't applying the spew patch?
|
This issue has been automatically marked as stale because it has not had any recent activity in the past 90 days. It will be closed if no further activity occurs. If you require additional support, please reply to this message. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've deleted the glog patch which was meant to squelch some verbose logging from the rex sdk. The patch no longer applies, and looking at the repo, it's changed quite drastically. I've tested by running a remote build and I don't see any spurious log lines in the build.log.