Implement an iofs.FS over the REAPI Tree proto #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goddenrich
reviewed
Nov 15, 2023
| return nil, os.ErrNotExist | ||
| } | ||
|
|
||
| // openFile downloads a file from the CAS and returns it as an iofs.File |
There was a problem hiding this comment.
I don't think it returns it as an iofs.File
There was a problem hiding this comment.
ah as in *file implements the iofs.File interface
goddenrich
reviewed
Nov 15, 2023
src/remote/fs/fs.go
Outdated
| func (fs *CASFileSystem) findNode(wd *pb.Directory, name string) (*pb.FileNode, *pb.DirectoryNode, *pb.SymlinkNode, error) { | ||
| name, rest, hasToBeDir := strings.Cut(name, string(filepath.Separator)) | ||
| // Must be a dodgy symlink that goes past our tree. | ||
| if name == ".." || name == "." { |
There was a problem hiding this comment.
I don't think "." should be ErrNotExist
goddenrich
reviewed
Nov 15, 2023
src/remote/fs/fs.go
Outdated
| mode: os.FileMode(file.NodeProperties.UnixMode.Value), | ||
| // Technically we could calculate this on demand by allowing info.Size() to download the file from the | ||
| // CAS... we don't need to for now though. | ||
| size: 0, |
There was a problem hiding this comment.
i thought the CAS stored the filesize without us needing to download it and calculated this
There was a problem hiding this comment.
Ah yeah! It's on the digest! Nice spot.
goddenrich
reviewed
Nov 15, 2023
src/remote/fs/fs.go
Outdated
| *info | ||
| } | ||
|
|
||
| // ReadDir is a slightly incorrect implementation of ReadDir. It deviates slightly as it will report all files have 0 |
There was a problem hiding this comment.
comment should be updated now we have the filesize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.