Make config loading use a virtual filesystem #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatskaari
commented
Nov 14, 2023
Comment on lines
+40
to
+49
| type osFS func(name string) (*os.File, error) | ||
|
|
||
| func (r osFS) Open(name string) (iofs.File, error) { | ||
| return r(name) | ||
| } | ||
|
|
||
| // HostFS returns an io/fs.FS that behaves the same as the host OS i.e. the same way os.Open works. | ||
| func HostFS() iofs.FS { | ||
| return osFS(os.Open) | ||
| } |
There was a problem hiding this comment.
Not sure why this doesn't exist in the go SDK tbh...
samwestmoreland
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful later on when we allow subrepos to have a filesystem based on the REAPI. We can plug in the remote FS in here so we can resolve config files without downloading the subrepo sources.