keep going flag #2932
Merged
keep going flag #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goddenrich
commented
Oct 25, 2023
goddenrich
force-pushed
the
keep-going
branch
from
67a1cb4 to
848292a
Compare
Tatskaari
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we introduce a flag --keep_going which will allow us to continue as far as we can with tasks. This can be useful if we want to collect all build failures for reporting at once rather than just the first one encountered.
This doesn't really work with our current shell output. currently we stop early with our output if we have build failures. I took a quick look and it wasn't very easy to change the shell output to display test results after failing builds so I intend to resolve this in a separate PR.