Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make provides add dependencies too #2915

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

peterebden
Copy link
Collaborator

Relevant: please-build/go-rules#162

It seems that if you don't do this, there is no direct dependency, and you can wind up with weird "should be built by now" errors. You are of course meant to ensure there's at least an indirect one but it's not clear to me that there's any reason for us not to just add this.

@peterebden peterebden merged commit cf51ad0 into thought-machine:master Oct 12, 2023
4 of 5 checks passed
@peterebden peterebden deleted the make-provides-add-a-dep branch October 12, 2023 16:42
peterebden added a commit to peterebden/please that referenced this pull request Oct 24, 2023
peterebden added a commit that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants