Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in k8s codelab #2914

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Typo in k8s codelab #2914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d3b77
Note
samwestmoreland Oct 1, 2023
e0e9238
Update docs
samwestmoreland Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ genrule(
plugins = {
"python": "v1.4.1",
"java": "v0.3.0",
"go": "v1.8.2",
"go": "v1.9.0",
"cc": "v0.4.0",
"shell": "v0.2.0",
"go-proto": "v0.2.1",
Expand Down
2 changes: 1 addition & 1 deletion docs/codelabs/k8s.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ spec:
```

### Kubernetes rules
Not that we've referenced the image `//hello-service/k8s:image` in the deployment. The kubernetes rules are able to
Note that we've referenced the image `//hello-service/k8s:image` in the deployment. The kubernetes rules are able to
template your yaml files substituting in the image with the correct label based on the version of the image we just
built! This ties all the images and kubernetes manifests together based on the current state of the repo making the
deployment much more reproducible!
Expand Down
Loading