Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the k8s codelab #2912

Merged
merged 2 commits into from
Oct 1, 2023
+8 −8
Merged

Fixes for the k8s codelab #2912

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68770c0
Fixes for the k8s codelab
Tatskaari Sep 29, 2023
31b6149
plugins
samwestmoreland Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions docs/codelabs/k8s.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ For the sake of this codelabs, we'll make a simple hello world HTTP service in P
### Initialising the project
```
$ plz init
$ go mod init github.com/exmaple/module
$ go mod init github.com/example/module
$ plz init plugin go
```

### Setup the Go plugin
### Set up the Go plugin

Add a go toolchain to `third_party/go/BUILD`
```python
Expand All @@ -61,8 +61,8 @@ go_toolchain(
And configure the plugin:
```
[Plugin "go"]
Target = //plguins:go
ImportPath = github.com/exmaple/module
Target = //plugins:go
ImportPath = github.com/example/module
GoTool = //third_party/go:toolchain|go
```

Expand Down Expand Up @@ -129,12 +129,12 @@ Let's create a base docker file for our repo that all our services will use in `
```
FROM ubuntu:22.04

RUN apt update && apt upgrade
RUN apt update -y && apt upgrade -y
```

### Docker build rules

To use the docker build rules, we need to install the docker plugin, as well as the shell plugin which it reuqires:
To use the docker build rules, we need to install the docker plugin, as well as the shell plugin which it requires:

`$ plz init plugin shell && plz init plugin docker`

Expand Down Expand Up @@ -217,7 +217,7 @@ $ cat plz-out/bin/hello_service/k8s/image.sh
Dockerfile - < plz-out/gen/hello_service/k8s/_image#docker_context.tar.gz
```

Note, this script takes care of building the base image for us so we don't have to orchestrate this ourselves.
Note, this script takes care of building the base image for us, so we don't have to orchestrate this ourselves.

## Creating a Kubernetes deployment
Duration: 5
Expand Down Expand Up @@ -271,7 +271,7 @@ deployment much more reproducible!

To add the kubernetes rules, run `plz init plugin k8s`.

Lets update `hello_service/k8s/BUILD` to build these manifests:
Let's update `hello_service/k8s/BUILD` to build these manifests:

```python
docker_image(
Expand Down
Loading