github_repo: strip v prefix if revision is any version number
#2832
Conversation
`github_repo` currently strips the `v` prefix from the file names in the zip file downloaded from GitHub if `revision` is a semver, since GitHub silently does the same if asked to archive the code for semver-like tags. It looks like this logic extends to more than just semvers, though - the same behaviour has been observed for strings that are simple dotted version numbers with any number of components (e.g. `v1.1.10.1`). Account for this in the prefix-stripping logic. Fixes thought-machine#2829.
chrisnovakovic
force-pushed
the
github_repo-strip-v-prefix
branch
from
51cb95e to
9a9a9b9
Compare
|
This issue has been automatically marked as stale because it has not had any recent activity in the past 90 days. It will be closed if no further activity occurs. If you require additional support, please reply to this message. Thank you for your contributions. |
Not stale, but I'm going to think of a more efficient way to implement this. |
|
This issue has been automatically marked as stale because it has not had any recent activity in the past 90 days. It will be closed if no further activity occurs. If you require additional support, please reply to this message. Thank you for your contributions. |
github_repocurrently strips thevprefix from the file names in the zip file downloaded from GitHub ifrevisionis a semver, since GitHub silently does the same if asked to archive the code for semver-like tags. It looks like this logic extends to more than just semvers, though - the same behaviour has been observed for strings that are simple dotted version numbers with any number of components (e.g.v1.1.10.1). Account for this in the prefix-stripping logic.Fixes #2829.