experiment/issue-175-encoders-without-json-du #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/Thoth.Json.Core/Encode.fs
Outdated
Comment on lines
104
to
107
| let inline sbyte (value: sbyte) = | ||
| { | ||
| new IEncodable with | ||
| member this.Encode(helpers) = | ||
| helpers.encodeIntegralNumber(uint32 value) | ||
| } | ||
|
|
||
| let inline byte (value: byte) = | ||
| { | ||
| new IEncodable with | ||
| member this.Encode(helpers) = | ||
| helpers.encodeIntegralNumber(uint32 value) | ||
| } | ||
|
|
||
| let inline int16 (value: int16) = | ||
| { | ||
| new IEncodable with | ||
| member this.Encode(helpers) = | ||
| helpers.encodeIntegralNumber(uint32 value) | ||
| } |
There was a problem hiding this comment.
Note fo later:
We should probably not cast to uint32 see #187
packages/Thoth.Json.Core/Encode.fs
Outdated
Comment on lines
132
to
119
| let inline int (value: int) = | ||
| { | ||
| new IEncodable with | ||
| member this.Encode(helpers) = | ||
| helpers.encodeIntegralNumber(uint32 value) | ||
| } |
There was a problem hiding this comment.
Note fo later:
We should probably not cast to uint32 see #187
|
Thank you for the PR and showing me that it was indeed possible to defer the concrete representation of the JSON. |
|
I suspect the CI is failing because of a bug in Fable Python trying to understand where |
|
Well ... member _.encodeList values = JS.Constructors.Array.from values
member _.encodeSeq values = JS.Constructors.Array.from valuesI feel like this place is a good place to start my investigation as seeing |
MangelMaxime
force-pushed
the
experiment/issue-175-encoders-without-json-du
branch
from
6604e92 to
afa6ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Encoder type to return IEncodable, deferring concrete representation of JSON.
Follows from the discussion here: #175 (comment)