AppLovin/internal advanced bidding #2
Conversation
|
Please note: There are some TODOs that have yet to be tackled |
|
Waiting on response(s) from AdMob |
| else | ||
| { | ||
| Log.e( TAG, "Failed to generate bid token" ); | ||
| signalCallbacks.onFailure( null ); |
There was a problem hiding this comment.
Add a reason for failure in the failure callback? Maybe even the error message we are logging above.
There was a problem hiding this comment.
Yea I thought about that - more code - but why not!
| @Override | ||
| public void collectSignals(RtbSignalData rtbSignalData, SignalCallbacks signalCallbacks) | ||
| { | ||
| // TODO: I hope that we do not use the SDK Key and Context from here to initialize SDK / get bid token with... |
There was a problem hiding this comment.
I don't think we would be initializing the SDK here. We initialize it in either initialize() or setUp().
According to AdMob's docs:
collectSignals()is called on a background thread, and has a timeout of 1 second.
So, we should not be doing any heavy duty work here and try to callback with a bid token ASAP.
There was a problem hiding this comment.
I understand, but we can't initialize our SDK in initialize() or setUp()(wherever that method is) b/c there is no Context parameter in those methods :/.
There was a problem hiding this comment.
Ah, makes sense. Didn't notice that they were not providing Context there.
|
|
||
| // TODO: Why is this not in the base adapter?! | ||
| // @Override | ||
| // public void setUp() |
There was a problem hiding this comment.
I don't see this method in RtbAdapter in the latest version of the GMA SDK. I'm guessing that this method may have been dropped in favor of initialize()
There was a problem hiding this comment.
:/ inconsistent with iOS - we are going to figure out what's up.
| @Override | ||
| public void adDisplayed(AppLovinAd ad) | ||
| { | ||
| Log.d( TAG, "Rewarded video dismissed" ); |
| @Override | ||
| public void adDisplayed(AppLovinAd ad) | ||
| { | ||
| Log.d( TAG, "Interstitial dismissed" ); |
| @Override | ||
| public void adDisplayed(AppLovinAd ad) | ||
| { | ||
| Log.d( TAG, "Banner dismissed" ); |
| } | ||
|
|
||
| @Override | ||
| public void updateConfiguration(final List<RtbConfiguration> list) |
There was a problem hiding this comment.
NOTE: Waiting on AdMob for action on this.
No description provided.