Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update show for GroupAlgebraElem with sparse rep #1688

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update show for GroupAlgebraElem with sparse rep #1688

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca029b7
Update show for GroupAlgebraElem with sparse rep
lgoettgens Nov 19, 2024
b3bec6b
fix: some type stability
lgoettgens Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/AlgAss/Elem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,10 @@
if !haskey(parent(a).group_to_base, g)
return zero(base_ring(parent(a)))
else
return a.coeffs_sparse[parent(a).group_to_base[g]]
return a.coeffs_sparse[parent(a).group_to_base[g]]::S

Check warning on line 266 in src/AlgAss/Elem.jl

View check run for this annotation

Codecov / codecov/patch

src/AlgAss/Elem.jl#L266 

Added line #L266 was not covered by tests
end
else
return a.coeffs[parent(a).group_to_base[g]]
return a.coeffs[parent(a).group_to_base[g]]::S
end
end

Expand Down Expand Up @@ -752,7 +752,7 @@
for (i, ci) in a.coeffs_sparse
push!(sum.args,
Expr(:call, :*, AbstractAlgebra.expressify(ci, context = io),
AbstractAlgebra.expressify(parent(a).base_to_group[i], context = IOContext(io, :compact => true))))
Expr(:call, :e, AbstractAlgebra.expressify(parent(a).base_to_group[i], context = IOContext(io, :compact => true)))))
end
end
print(io, AbstractAlgebra.expr_to_string(AbstractAlgebra.canonicalize(sum)))
Expand Down
Loading