Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mult dep2 #1673

Merged
merged 10 commits into from
Nov 12, 2024
Merged

Mult dep2 #1673

merged 10 commits into from
Nov 12, 2024

Conversation

fieker
Copy link
Collaborator

@fieker fieker commented Nov 6, 2024

No description provided.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 68.23529% with 108 lines in your changes missing coverage. Please review.

Project coverage is 75.92%. Comparing base (b085401) to head (d3af985).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/NumField/NfAbs/MultDep.jl 68.15% 107 Missing ⚠️
src/Sparse/UpperTriangular.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
- Coverage   75.95%   75.92%   -0.04%     
==========================================
  Files         361      362       +1     
  Lines      113878   114217     +339     
==========================================
+ Hits        86498    86714     +216     
- Misses      27380    27503     +123     
Files with missing lines Coverage Δ
src/Hecke.jl 51.11% <ø> (ø)
src/LocalField/Conjugates.jl 79.48% <100.00%> (+2.68%) ⬆️
src/Map/NfOrd.jl 66.41% <100.00%> (-0.22%) ⬇️
src/Sparse/UpperTriangular.jl 0.00% <0.00%> (ø)
src/NumField/NfAbs/MultDep.jl 68.15% <68.15%> (ø)

... and 28 files with indirect coverage changes

Try
  elementary_divisors(sparse_matrix(identity_matrix(ZZ, 2)))
without will give 3 EDs, the last one being 0
Needs further work on the Ge stuff and some of the internal
interface are bad.
Example
  k, a = wildanger_field(5,13);
  zk = lll(maximal_order(k))
  class_group(zk)
  h = zk.__attrs[:ClassGrpCtx]
  r = vcat(h.R_gen, h.R_rel);
  r = [x for x = r if isa(x, AbsSimpleNumFieldElem)]

  q = Main.MultDep.syzygies(r)

Then the rows of q are the relations
@fieker fieker merged commit 5341ab1 into master Nov 12, 2024
18 checks passed
@fieker fieker deleted the MultDep2 branch November 12, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant