Skip to content

Commit

Permalink
deal with 0 properly in lift
Browse files Browse the repository at this point in the history
  • Loading branch information
fieker committed Nov 8, 2024
1 parent 5edb844 commit a59230a
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/NumField/NfAbs/MultDep.jl
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ function syzygies_units_mod_tor(A::Vector{FacElem{AbsSimpleNumFieldElem, AbsSimp
if y === nothing
prec *= 2
@vprint :qAdic 1 "increase prec to ", prec
lu = matrix([conjugates_log(x, C, prec, all = false, flat = true) for x = u])'
lu = transpose(matrix([conjugates_log(x, C, prec, all = false, flat = true) for x = u]))

Check warning on line 277 in src/NumField/NfAbs/MultDep.jl

View check run for this annotation

Codecov / codecov/patch

src/NumField/NfAbs/MultDep.jl#L277

Added line #L277 was not covered by tests
break
end
push!(s, y)
Expand Down Expand Up @@ -405,6 +405,9 @@ end

#TODO: different name ...
function lift_reco(::QQField, a::PadicFieldElem; reco::Bool = false)
if iszero(a)
return QQ(0)
end
if reco
u, v, N = canonical_split(a)
R = parent(a)
Expand All @@ -418,7 +421,7 @@ function lift_reco(::QQField, a::PadicFieldElem; reco::Bool = false)
return x*prime(R, v)
end
else
return lift(FlintQQ, a)
return lift(QQ, a)

Check warning on line 424 in src/NumField/NfAbs/MultDep.jl

View check run for this annotation

Codecov / codecov/patch

src/NumField/NfAbs/MultDep.jl#L424

Added line #L424 was not covered by tests
end
end

Expand Down

0 comments on commit a59230a

Please sign in to comment.